Commit Graph

3 Commits

Author SHA1 Message Date
hanlap 782ecbb49c Fix TIER 2 HIGH (66h) Part C - Ops & Infrastructure
Task 1: Add DB Indexes (#4)
- Created migration: 5_add_candle_indexes.py
- Added composite index ix_candles_symbol_tf_time on (symbol_id, timeframe, time)
- Expected query performance improvement: 30-40% faster for candle lookups

Task 2: Add Input Validation Everywhere (#2)
- Created app/schemas/input_validation.py with Pydantic models
- Validates: timeframe, exchange, amounts, symbols, orders
- Implements per-endpoint validation for all API queries
- Updated backtest.py endpoints with comprehensive input validation
- Standardized error responses with validation details

Task 3: Fix Migration Strategy (#30)
- Created app/core/migrations.py with migration utilities
- Implemented migration lock mechanism to prevent concurrent migrations
- Replace create_all() with Alembic upgrade in main.py
- Added rollback capabilities for failed migrations
- Safety checks to ensure DB consistency

Task 4: Remove Default Credentials (#28)
- Removed hardcoded demo_user/demo_pass from config.py
- Credentials must now be provided via environment variables
- Enforces secure credential management

Task 5: Fix Redis URL (#29)
- Corrected docker-compose.yml redis URLs
- Changed from redis://redis:***@db:5432/trading_portal
- To correct: redis://redis:6379/0
- Applied to both backend-api and backend-scheduler services

All changes follow secure coding patterns and maintain backward compatibility.
Migration tests pending - see VERIFICATION_RESULTS.md
2026-07-10 11:59:56 +00:00
Le 625c2b3773 Add walk-forward backtest optimization to mitigate signal overfitting (item m)
Rolling train/test folds over 3 years of data auto-optimize the three
cheap-to-tune trading parameters (STRONG/BUY score thresholds, max hold
time) via grid search on each fold's train window, then evaluate purely
on the held-out test window. Stitching all out-of-sample results gives
an honest performance estimate uninflated by tuning against the same
data used to score it.

Split signal_scoring.py's expensive 13-algorithm scoring from its cheap
final threshold classification so grid search can replay many parameter
combinations without recomputing indicators each time. Moved the
backtest engine (fetch/precompute/simulate) out of the API layer into
app/services/backtest_engine.py so both /backtest/run and the new
walk-forward optimizer share one implementation instead of drifting
copies — same rationale as the earlier signal_service.py split (item h).

Also merges two long-diverged Alembic migration heads discovered while
adding the walk_forward_results table, so `alembic upgrade head` has a
single target again.

New: POST/GET/DELETE /walk-forward/* endpoints, a Walk-Forward tab on
the Backtest page (fold table, out-of-sample equity curve, run history).
19 new backend tests (153 total, all passing).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-04 09:15:21 +07:00
hanlap 34a1e91541 Initial commit: Trading Portal - FastAPI + React + PostgreSQL 2026-07-03 13:08:22 +00:00